[feature] throw sql transform exception,locate error expression #9227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses issue #9125 by enhancing error handling in the SQL transformation logic. Key changes include:
- Wrapping the SQL expression evaluation in a try-catch block to throw a more specific exception.
- Introducing new exception classes and error codes to better pinpoint errors in SQL processing.
- Adding new files for SqlTransformException and SqlTransformErrorCode to support the improved exception handling.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/sql/zeta/ZetaSQLEngine.java | Added exception handling for SQL expression evaluation and improved error reporting. |
| seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/exception/SqlTransformException.java | New exception class for SQL transformation errors. |
| seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/exception/SqlTransformErrorCode.java | New error code enum defining the SQL transformation error codes. |
Comments suppressed due to low confidence (1)
seatunnel-transforms-v2/src/main/java/org/apache/seatunnel/transform/sql/zeta/ZetaSQLEngine.java:295
- Consider adding a space after the comma in the error message for improved readability, e.g., "Failed to execute sql expression, the error expression is %s".
String.format("Failed to execute sql expression,the error expression is %s", expression),
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
resolve issue #9125
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.